make check-lit + grep escape characters

Hi all. I found that if you want to use grep with escape characters in lit, you should pass it within the double slash (\\). Since the first one is captured by python scripts and the second one by grep.
E.g. if you want to capture "grep icmp ule" you should pass
"grep icmp\\ ule"

So I'm going to commit the test with strings like this. How stable this feature in lit?

-Stepan.

Why are you using grep and not FileCheck?

-eric

I just want to update test/Transforms/LowerSwitch/feature.ll that already uses grep.
It uses grep + count, probably due to shorter construction.

-Stepan.

Eric Christopher wrote:

I just want to update test/Transforms/LowerSwitch/feature.ll that already uses grep.
It uses grep + count, probably due to shorter construction.

Might as well just update it to FileCheck while you're at it.

-eric

I just want to update test/Transforms/LowerSwitch/feature.ll that
already uses grep.
It uses grep + count, probably due to shorter construction.

If you are touching such a test, please convert it to FileCheck. Use of ‘grep’ in tests is an endless source of problems, and we are lazily moving toward a world where only FileCheck is used.

OK.

Chandler Carruth wrote: