misleading documentation for PPCallbacks::FileSkipped

Hello,

It looks like the name and documentation of the first parameter is incorrect
   virtual void FileSkipped(const FileEntry &ParentFile,
                            const Token &FilenameTok,
                            SrcMgr::CharacteristicKind FileType) {
   }

passed ParentFile is in fact SkippedFile.

The code from Preprocessor::HandleIncludeDirective which calls FileSkipped:

   // Ask HeaderInfo if we should enter this #include file. If not, #including
   // this file will have no effect.
   if (!HeaderInfo.ShouldEnterIncludeFile(File, isImport)) {
     if (Callbacks)
       Callbacks->FileSkipped(*File, FilenameTok, FileCharacter);
     return;
   }

Thanks,
Vladimir.

Looks that way at first glance, feel free to submit a patch as there seem to be quite a few places that need updating.

Hello Nikola,

Please, review and apply attached patch.

Thanks!
Vladimir.

SkippedFile.patch (4.08 KB)

Sorry for not telling you earlier, can you please upload this to Phabricator and CC me?

Hello Nikola,

I’ve created , but for unknown reason as soon as focus lost “reviewer” or “Subscribers” fields it’s content is erased, so I can not add you and cfe list there. Could you update appropriately. Thank you! Vladimir.

Hello Nikola,

I’ve created http://reviews.llvm.org/D9109, but for unknown reason as soon as focus lost “reviewer” or “Subscribers” fields it’s content is erased, so I can not add you and cfe list there.

What browser are you using?

Hello Manuel,

I use Firefox.
I tried to edit fields from Solaris ``and from Ubuntu and failed in both cases.

Hope it helps,
Vladimir.