missing return in lib/Sema/SemaDeclAttr.cpp???

Clang Frontend
1

In HandleCallConvAttr(), the case for "AttributeList::AT_thiscall" isn't
followed by a return, so the case for "AttributeList::AT_cdecl" will be
executed also. Is this intentional?

The code appears to have been added in this rev:

r104026 | dgregor | 2010-05-18 09:57:00 -0700 (Tue, 18 May 2010) | 2 lines

Add support for Microsoft's __thiscall, from Steven Watanabe!

-Dawn

2

In HandleCallConvAttr(), the case for "AttributeList::AT_thiscall" isn't
followed by a return, so the case for "AttributeList::AT_cdecl" will be
executed also. Is this intentional?

Definitely a bug. Nice catch!

The code appears to have been added in this rev:

r104026 | dgregor | 2010-05-18 09:57:00 -0700 (Tue, 18 May 2010) | 2 lines

... and the egg is on my face.

Fixed in Clang r112552.

  - Doug