Missing space in lib/buildit of libc++

Clang Frontend
#1

Hi!

Just a little note to libc++'s lib/buildit script:

EXTRA_FLAGS="-std=c++0x -fstrict-aliasing -Wall -Wextra -Wshadow -Wconversion \
             -Wnewline-eof -Wpadded -Wmissing-prototypes -Wstrict-aliasing=2 \
             -Wstrict-overflow=4"

And later:

EXTRA_FLAGS+="-isysroot ${SDKROOT}"

I think there is a missing space.

regards,
Samuel

#2

Hi Samuel,

Hi!

Just a little note to libc++'s lib/buildit script:

EXTRA_FLAGS="-std=c++0x -fstrict-aliasing -Wall -Wextra -Wshadow -Wconversion \
             -Wnewline-eof -Wpadded -Wmissing-prototypes -Wstrict-aliasing=2 \
             -Wstrict-overflow=4"

And later:

EXTRA_FLAGS+="-isysroot ${SDKROOT}"

I think there is a missing space.

Have you tried it?
GNU make automatically adds a space when appending with +=

See the make documentation (info make):
"""
6.6 Appending More Text to Variables
...
     variable := value
     variable += more

is exactly equivalent to:

     variable := value
     variable := $(variable) more
"""

Note the space before "more".

Hope this helps,
Csaba