More cmake breakage

Are you doing something in your cmake that would cause these to be
ignored if manually set? If so please don't.

    CMAKE_ASM_COMPILER
    arch

Attached patch should fix this

omp_mod.patch (1.64 KB)

The changes were part of this review that was posted more than a week ago: http://reviews.llvm.org/D12211
I must admit that I didn't check the Fortran build...

The proposed patch looks good to me, but I think that the CMAKE_CURRENT_BINARY_DIR isn't needed for configure_file (it at least works for me without).

I'm fairly certain that's needed as well. Someone please push this and
we can back out that piece if it breaks anything for anyone else or
figure out the correct way later.

Thanks

I've committed the patch, svn revision 246426.

Thanks,
Andrey

It doesn't matter anymore now that it's committed, but my point was that 'configure_file' doesn't need the absolute path with the current binary directory.
This isn't consistent with the other calls in this file and the CMake documentation says:

If <output> is a relative path it is evaluated with respect to the current binary directory.

Sorry if that was unclear: The fix itself was needed, the build was indeed broken!

Greetings,
Jonas

Thanks

From: "C Bergström via Openmp-dev" <openmp-dev@lists.llvm.org>
To: "Jonas Hahnfeld" <Hahnfeld@itc.rwth-aachen.de>
Cc: "LLVM-OpenMP (openmp-dev@lists.llvm.org)" <openmp-dev@lists.llvm.org>
Sent: Monday, August 31, 2015 6:47:49 AM
Subject: Re: [Openmp-dev] More cmake breakage

> It doesn't matter anymore now that it's committed, but my point was
> that 'configure_file' doesn't need the absolute path with the
> current binary directory.
> This isn't consistent with the other calls in this file and the
> CMake documentation says:
>> If <output> is a relative path it is evaluated with respect to the
>> current binary directory.
> Sorry if that was unclear: The fix itself was needed, the build was
> indeed broken!
>
> Greetings,
> Jonas
>
>> From: Churbanov, Andrey [mailto:Andrey.Churbanov@intel.com]
>> Sent: Monday, August 31, 2015 11:42 AM
>> To: C Bergstrom; Hahnfeld, Jonas; Hans Wennborg
>> Cc: LLVM-OpenMP (openmp-dev@lists.llvm.org)
>> Subject: RE: [Openmp-dev] More cmake breakage
>>
>> I've committed the patch, svn revision 246426.

Thanks
----------
I'd still like commit access to serve as a backup.

Given that you've contributed to this project, you're as entitled as anyone else to request commit access to LLVM's repositories. Please see http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for instructions.

Thanks again,
Hal

Are you doing something in your cmake that would cause these to be ignored if manually set? If so please don't.

CMAKE_ASM_COMPILER
arch

These variables are ignored because they aren't used anywhere in any *.cmake nor CMakeLists.txt file. (I have the C compiler assembling z_Linux_asm.s and arch was changed to LIBOMP_ARCH months ago?)

-- Johnny

Ok I looked on our side and I see we were setting arch and LIBOMP_ARCH
both. (I remember this breakage as well)

Side note: You should absolutely not be setting the "C" compiler as
the assembler. I realize that most compilers will magically just do
the right thing (tm) for .s files, but I'm still not for it.