[PATCH 1/2] Add cross for double3 and double4

Both these patches look good. How are you testing these?

-Tom

Good that you raised this question: This is code I lifted from our OpenCL static race detection tool (GPUVerify), which is not the most rigorous environment to test the code in (due to the way the tool treats floating point operations). So, suggestions how I can better test this are welcome.

Jeroen

Good that you raised this question: This is code I lifted from our OpenCL static race detection tool (GPUVerify), which is not the most rigorous environment to test the code in (due to the way the tool treats floating point operations). So, suggestions how I can better test this are welcome.

We use piglit for testing: http://cgit.freedesktop.org/piglit and I
usually try to add a test there when I implement a new builtin. If
you have access to an OpenCL implementation, you could try to add tests
there. See tests/cl/program/execute and generated_tests/*-cl-*.py for
some good test examples.

-Tom

Good that you raised this question: This is code I lifted from our OpenCL static race detection tool (GPUVerify), which is not the most rigorous environment to test the code in (due to the way the tool treats floating point operations). So, suggestions how I can better test this are welcome.

We use piglit for testing: http://cgit.freedesktop.org/piglit and I
usually try to add a test there when I implement a new builtin. If
you have access to an OpenCL implementation, you could try to add tests
there. See tests/cl/program/execute and generated_tests/*-cl-*.py for
some good test examples.

Thanks for pointing me to this. Unfortunately I’m not in a very good position to test this right now, because I don’t have access to a proper OpenCL implementation at the moment. My apologies.

Jeroen

I have pushed these two patches. Thanks!

-Tom