[PATCH 1/3] Require LLVM 3.6 and bump version to 0.1.0

Some functions are implemented using hand-written LLVM IR and
LLVM assembly format is allowed to change between versions, so we
need to start tieing libclc to a specific version of LLVM.

the first two LGTM,
I don't know enough to review the third one

Looks good to me.

If we’re going to start requiring the newest llvm explicitly (used to be an implicit requirement), do we want to eventually consider cutting a branch before bumping the llvm version (or tied to the llvm release schedule)?

Maybe it’s more appropriate to start cutting releases when we have full support for CL 1.0/1.1.

–Aaron

LGTM.

–Aaron


r600/lib/workitem/get_work_dim.ll | 2 ±
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/r600/lib/workitem/get_work_dim.ll b/r600/lib/workitem/get_work_dim.ll
index 1220153…1f86b5e 100644
— a/r600/lib/workitem/get_work_dim.ll
+++ b/r600/lib/workitem/get_work_dim.ll
@@ -5,4 +5,4 @@ define i32 @get_work_dim() nounwind readnone alwaysinline {
ret i32 %x
}

-!0 = metadata !{ i32 1, i32 4 }
+!0 = !{ i32 1, i32 4 }

the first two LGTM,
I don’t know enough to review the third one

Likewise.

Is this the only builtin that needs updating at this time, or just the only one updated here?

I’d check now, but I’m on a cell phone at the parents house right now and don’t want to forget to check when by a computer later.

–Aaron


r600/lib/workitem/get_work_dim.ll | 2 ±
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/r600/lib/workitem/get_work_dim.ll b/r600/lib/workitem/get_work_dim.ll
index 1220153…1f86b5e 100644
— a/r600/lib/workitem/get_work_dim.ll
+++ b/r600/lib/workitem/get_work_dim.ll
@@ -5,4 +5,4 @@ define i32 @get_work_dim() nounwind readnone alwaysinline {
ret i32 %x
}

-!0 = metadata !{ i32 1, i32 4 }
+!0 = !{ i32 1, i32 4 }

the first two LGTM,
I don’t know enough to review the third one

Likewise.

Is this the only builtin that needs updating at this time, or just the only one updated here?

This is the only file with metadata in it.

Looks good to me too.

Jeroen

I would prefer to have a branch, so we easily know what the last known good version is that works with the current release version of clang/llvm.

Jeroen

I would prefer to have a branch, so we easily know what the last known good version is that works with the current release version of clang/llvm.

I have created the release_35 branch, and also pushed the first two patches.

-Tom

I would prefer to have a branch, so we easily know what the last known good version is that works with the current release version of clang/llvm.

I have created the release_35 branch,

Thanks!

One small niggle: it seems the branch wasn’t propagated to the git repository: http://llvm.org/git/libclc.git

Jeroen