[patch] add support for PIC on linux x86-64

Project Infrastructure LLVM Dev List Archives
1

Hello, Rafael

With this patch I was able to bootstrap gcc in linux x86-64 with
shared libraries enabled :slight_smile:

Awesome! But... -ENOPATCH :frowning:

2

Attached now.

Thanks,

x86-64-plt.patch (9.7 KB)

3

Hi Rafael,

Thanks a lot for working on this!

I have one question about the patch; why did you choose too add a new
enum, PICCallStyle, instead of reusing (possibly with some adjustments)
the existing PICStyle enum?

Thanks,

Dan

4

Hello, Rafael

Awesome! But... -ENOPATCH :frowning:

Attached now.

Hi Rafael,

Thanks a lot for working on this!

I have one question about the patch; why did you choose too add a new
enum, PICCallStyle, instead of reusing (possibly with some adjustments)
the existing PICStyle enum?

Yes, please remove PICCallStyle and have printPLT check for pic relocation model and Subtarget.isTargetELF().

And where you are modifying this part of the code. Please rename printGOT, printStub, and printPLT to something that indicates they are predicate functions. Perhaps shouldPrintGOT, etc.?

Thanks,

Evan

5

Yes, please remove PICCallStyle and have printPLT check for pic
relocation model and Subtarget.isTargetELF().

Done.

And where you are modifying this part of the code. Please rename
printGOT, printStub, and printPLT to something that indicates they are
predicate functions. Perhaps shouldPrintGOT, etc.?

Done.

Updated patch attached.

Thanks,

Evan

Cheers,

x86-64-plt.patch (7.91 KB)

6

Patch looks great to me, if it causes no regressions on linux/x86 please commit! Thanks a lot Rafael!

-Chris