Patch "aftermath"

<cc'ing cfe-dev since this is a general question>

Hello,

Sunday and yesterday I submitted a patch for clang on the cfe-dev list (the "Patch & feedback request" thread). I have one question left, which was not answered, so that is when I am mailing you directly: what is the procedure now, or how do things work from here on? Is somebody going to commit it to svn, should/can I do that myself, etc.

It doesn't look like the final patch got reviewed (I injected confusion into the thread by thinking it was objc related). Once it has, you can commit it if you have commit access, or if not, please ask someone to commit it for you.

Furthermore, I would like to contribute some more patches, for example for the other "FIXME" in that file. For that, are there things I should be aware of (like no-go/being-worked-on zones)?

Not that I'm aware of. After you've gotten a few patches committed, please feel free to contact me to get direct commit access, per:
http://llvm.org/docs/DeveloperPolicy.html

-Chris

Okay, clear. Attached is a new version where I fixed a range-bug.

-- Erik.

unreachable-exception-handlers.patch (4.94 KB)

Erik Verbruggen wrote:

Attached is a new version where I fixed a range-bug.
  

Looks good. Do you have commit access or should I commit it?

Sebastian

I don't have commit access, so it would be great if you could commit it.

-- Erik.

Erik Verbruggen wrote:

Erik Verbruggen wrote:
    

Attached is a new version where I fixed a range-bug.
  

Looks good. Do you have commit access or should I commit it?
    
I don't have commit access, so it would be great if you could commit it.
  

Done.
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090727/019742.html

Thank you for working on this.

Sebastian