[PATCH] amdgcn: Correct return types to be size_t

Runtimes OpenCL
#1

0001-amdgcn-Correct-return-types-to-be-size_t.patch (1.61 KB)

#2

LGTM.

#3

Is size_t 64bit even for mesa opencl? the pointer is cast to (uint *).

Jan

#4

clover currently incorrectly reports the device pointer size as 32. If something is using uint it is incorrect

#5

>
>
>
> Is size_t 64bit even for mesa opencl? the pointer is cast to (uint
> *).
>
> Jan
>
> >
> > _______________________________________________
> > Libclc-dev mailing list
> > Libclc-dev@lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev
clover currently incorrectly reports the device pointer size as 32.
If something is using uint it is incorrect

ah right, clover hardcodes offsets to cl_uint:

  case module::argument::grid\_offset: \{
     for \(cl\_uint x : pad\_vector\(\*q, grid\_offset, 0\)\) \{
        auto arg = argument::create\(marg\);

        arg\->set\(sizeof\(x\), &x\);
        arg\->bind\(\*this, marg\);
     \}
     break;
  \}

that's why it worked with cast to (uint *)

Jan