[patch] arm: external weak in constant pool

Project Infrastructure LLVM Dev List Archives
1

Adds external weak symbols of constant pool to ExtWeakSymbols set.

Lauro

llvm.patch (1021 Bytes)

weakConstantPool.ll (298 Bytes)

2

Hi Lauro,

Just a stylistic remark; In your "llvm.patch" file, there are tabs in
these lines:

+ if (GV->hasExternalWeakLinkage()) {
+ ExtWeakSymbols.insert(GV);
+ }

Others will need to review the patch for correctness, though.

-bw

3

without tabs

Lauro

2006/12/20, Bill Wendling <isanbard@gmail.com>:

llvm.patch (1.02 KB)

4

without tabs

Looks great, applied:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20061218/041706.html

Thanks,

-Chris