[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

Johannes,

This patch seems to be causing test failures when I just do "ninja
check", without running "ninja" or "ninja all" first.

$ CC=clang CXX=clang++ cmake -G Ninja ~/git/llvm-project/llvm
-DLLVM_USE_LINKER=lld -DLLVM_PARALLEL_LINK_JOBS=4
-DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 && ninja check
[...]
FAIL: LLVM :: tools/llvm-config/system-libs.test (32608 of 34640)
******************** TEST 'LLVM :: tools/llvm-config/system-libs.test'
FAILED ********************
Script:

Hi Jay,

I am not sure why this happens.
Can you give me some information so I can reproduce it:
  Is this happens for a clean build?
  Is Clang build as well?

I think the SYSTEM_LIBS macro doesn't contain the new
libLLVMFrontendOpenMP but I don't know why.

Thanks,
Johannes

This seems to be happening to me, too. I think this happens for me on “ninja check-llvm” in a clean build. Let me know if you need more info.

Perhaps you need to add something to LLVM_TEST_DEPENDS? https://github.com/llvm/llvm-project/blob/44c167ace998b41b7f8cbe6acd283c8ba9b0b5a3/llvm/test/CMakeLists.txt#L39

I think the problem is that only clang has a dependence on the new
library and when you check LLVM without building clang it does not exist
yet. I will commit a LLVM patch today that will cause LLVM to have a
dependence on the new library as well. That should, I hope, fix the
problem.

Jay, Hiroshi, did [0] resolve the problem you've seen.

[0] https://github.com/llvm/llvm-project/commit/d23c61490c282a7a8f29aaa5c021cbfdaf87fb6f

Yes, it works for me. Thank you!

Jay.

Yay!

Thanks for reporting this and your patience!