[PATCH] Fix recompileAndRelinkFunction

Gianluca_Guida · December 19, 2009, 11:36pm

Hello,

JIT::recompileAndRelinkFunction's runJITOnFunction does not use the
MCI arg, causing null pointer deferences at every call.

Attached patch makes runJITOnFunction more reliable.

Thanks,
Gianluca

Chris_Lattner · December 22, 2009, 5:14am

When would MCI be null?

-Chris

Gianluca_Guida · December 22, 2009, 8:23am

Everytime you call recompileAndRelinkFunction. It calls
runJITOnFunction without specifying the MCI argument, which get
defaulted to NULL.

Gianluca

Jeffrey_Yasskin1 · December 22, 2009, 4:51pm

Please add a test to
http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/JIT/JITTest.cpp?view=markup
verifying that recompileAndRelinkFunction() keeps working. Then this
fix will look fine to me.

Gianluca_Guida · December 22, 2009, 6:27pm

Here it is. Unfortunately I'm not exactly a C++ guy so I'm open to
change this code after any comment you might want to have.

Gianluca

Jeffrey_Yasskin1 · December 22, 2009, 11:19pm

The test looks great. Thanks for the patches! I've added a couple
comments and committed them:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20091221/093013.html

Jeffrey