[PATCH] .gitignore: add rules for a clean worktree

Add several .gitignore rules to various directories to ensure a clean
worktree after a default build.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>

Hi,

These gitignore lists require maintenance. Is is possible to express
the same set of filenames as patterns like '*.inc' in the root
gitigrore file, so that adding/removing a new generated file does not
require updating gitignore?

Dmitri

Hi Dmitri,

Dmitri Gribenko wrote:

Hi Dmitri,

Dmitri Gribenko wrote:

Add several .gitignore rules to various directories to ensure a clean
worktree after a default build.

Hi,

These gitignore lists require maintenance. Is is possible to express
the same set of filenames as patterns like '*.inc' in the root
gitigrore file, so that adding/removing a new generated file does not
require updating gitignore?

That's a valid concern, but there are plenty of *.inc files that
aren't meant to be ignored; for example lib/Support/Unix/Host.inc. I
can't think of any other patterns that would further simplify my
patch. Also, it's idiomatic to use a per-directory .gitignore rather
than one toplevel .gitignore.

I was under the impression that in-source-tree builds were an unsupported configuration. It's certainly strongly discouraged. I'm not fond of the idea of making it easier, especially when there's a maintenance cost to doing so.

-Jim

I was under the impression that in-source-tree builds were an unsupported
configuration. It's certainly strongly discouraged. I'm not fond of the
idea of making it easier, especially when there's a maintenance cost to
doing so.

Strongly discouraged, and yes, this.

-eric

FWIW, if in-tree builds work for CMake, I consider that a bug and will fix it.

By making sure that it no longer works for CMake? haha
On a more serious note, what would be the reason to support in-tree builds?

-Krzysztof

Chandler Carruth wrote:

FWIW, if in-tree builds work for CMake, I consider that a bug and will fix it.

How else am I supposed to build LLVM? I ran the toplevel configure
and make script.

Ram

Run configure in a different directory from the source.

- Michael Spencer