[patch] move ExtWeakSymbols to AsmPrinter

Project Infrastructure LLVM Dev List Archives
1

The attached patch moves the ExtWeakSymbols to the AsmPrinter class
and the code that emits the ".weak" directives to
AsmPrinter::doFinalization.

This is just code factoring. No functionality changes.

Best Regards,
Rafael

llvm.patch (5.26 KB)

2

Looks good, one request though: if practical, it would be nice to switch this to be set<GlobalValue*> instead of set<std::string>.

-Chris

3

Looks good, one request though: if practical, it would be nice to switch
this to be set<GlobalValue*> instead of set<std::string>.

Attached

-Chris

Rafael

llvm.patch (7.47 KB)

4

OK to commit?

Rafael

5

Sorry for the delay, looks great, please apply!

-Chris