patch proposal: replacing strcasestr() w/strncasecmp() for beg-of-haystack comparison

Hello LLDB Developers ++

I would like to propose the following patch to replace selected instances of strcasestr() with strcasecmp()

All of these instances are instances where the string being searched for is being compared against only the beginning of the test string. this can be seen in the patch in the value of the equality (i.e. ==) test.

The man page confirms that strcasestr() is a non-standard extension.

This patch build with xcode … and with gcc under MinGW.

thanks in advance for any review/feedback/commit .

strcasestr-strncasecmp.124846.patch (21.3 KB)

ATT00001.htm (1014 Bytes)

% svn commit
Sending source/Plugins/Disassembler/llvm/DisassemblerLLVM.cpp
Sending source/Plugins/Process/MacOSX-User/source/ProcessMacOSXLog.cpp
Sending source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
Sending source/lldb-log.cpp
Transmitting file data ....
Committed revision 124889.