PATCH (rest of code changes) "bytecode" --> "bitcode"

Project Infrastructure LLVM Dev List Archives
1

Here is the bulk of the sanitizing.

My residual doubts center around the question
whether we still do/want to support (un)compressed *byte*code
in 2.0/2.1.

I need a definitive word on this to proceed.

My understanding is that bytecode is already gone, but there are
still some functions/enums that really deal with *byte*code
(instead of *bit*code).

I did not touch those areas, so the attached patch is
for review about the IMO undisputed changes.

What is still missing:

- removing any genuine bytecode stuff (magic/filetype detection, etc.)
- Configury/Makefiles related sanitizing
- doc changes (.pod and .html files)
- anything else grep comes up with (should be next to nothing)

If anybody feels the urge to review the attached patch, feel free
and concentrate on Path.h/cpp and friends.

I plan to commit this late today or tomorrow (given that all the tests pass).

Then I proceed with my plan.

Cheers,

  Gabor

bitcode-changes.diff (67 KB)

2

Hi Gabor,

I scanned the patches quickly. Looks right to me.

Reid.

3

Here is the bulk of the sanitizing.

Nice, thanks Gabor!

My residual doubts center around the question
whether we still do/want to support (un)compressed *byte*code
in 2.0/2.1.
I need a definitive word on this to proceed.

There is now no longer a distinction between compressed and uncompressed bitcode. We just have bitcode, which has one format.

My understanding is that bytecode is already gone, but there are still some functions/enums that really deal with *byte*code (instead of *bit*code). I did not touch those areas, so the attached patch is for review about the IMO undisputed changes.

Ok. These sorts of changes are also good to do.

If anybody feels the urge to review the attached patch, feel free
and concentrate on Path.h/cpp and friends.

I plan to commit this late today or tomorrow (given that all the tests pass).

This looks good to me!

-Chris