[PATCH] use-diet for review

Chris Lattner wrote:

Hi Gabor, I don't see OperandTraits.h.

Sorry, I relied "svn diff" to include freshly added files.
Apparently it did not :-/

Here are they.
I pondered of putting all in Use.cpp into Value.cpp,
but I am not so sure.

Cheers,

  Gabor

OperandTraits.h (5.31 KB)

Use.cpp (3.82 KB)

svn add file
   svn diff .

will show it.

   svn add file
   svn diff .

will show it.

and "svn st" will show you what files you forgot to add ... or
which one you forgot to exclude via "svn propedit svn:ignore
<path-to-directory>".

Mike, Holger,

thanks for the tips, but being a long-time subversion
user, I already knew this all :slight_smile:

The problem was that I did an SVN merge from branch
to trunk, and I ended up with:

...
M include/llvm/User.h
A + include/llvm/OperandTraits.h
M include/llvm/Instruction.h
...

The little "+" after the "A" means, the file got
copied unchanged, and I think this is the reason
why it got excluded from "svn diff".

Anyway, the files can also be inspected by
"svn cat http://llvm.org/svn/llvm-project/llvm/trunk/include/llvm/OperandTraits.h"
etc.

Cheers,

    Gabor

Anyway, the files can also be inspected by
"svn cathttp://llvm.org/svn/llvm-project/llvm/trunk/include/llvm/OperandTraits.h"
etc.

Obviuosly that should be

<http://llvm.org/svn/llvm-project/llvm/branches/ggreif/use-diet/
include/llvm/OperandTraits.h>

*blush*

That's annoying (wrong).