Patches for MinGW Build instructions

Hi,

Here is my first try to document, how to build the llvm suite for MinGW.

Henrik.

diff.zip (3.02 KB)

The GettingStarted patch looks fine to me, and I've applied it here:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050207/023986.html

The other patch does not look ok. In particular, it would be much better to submit patches to make MinGW work as much like other platforms as possible. In particular, instead of telling the user to patch their sources and pass funny flags into make, it would be better to apply the patch to mainline CVS and fix the makefiles. :slight_smile:

Thanks,

-Chris

Chris already committed your patch, but I changed it as follows:

http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050207/023987.html

Your patch is good for a text file, but since you submitted a patch for
HTML documentation, links should use <a href="">, lists should be in a
<ul> or <ol> with <li> tags, and code or command lines should be in
<tt>. For large blocks of code or command-line interaction, we have
<div class="doc_code">, grep for it in the docs and see what it looks
like.

Actually, looking closer, I think that some of the content added to the GettingStarted.html file should be moved to the HowToBuildTheCFE document. Specifically I'm thinking of:

"If you want to compile the C/C++ frontend, then upgrade to texinfo-4.5+ from source." ... so I removed it.

Also, I'm not sure what this is needed for:

"If you need to create a library for an MS DLL, do the following:

    1. pexports /C/WINNT/SYSTEM32/file.dll | sed "s/^_//" > /C/MinGW/lib/file.def
    2. Edit file and append @<ordinal> to the missing function name
    3. dlltool.exe -k -d /C/MinGW/lib/file.def -l /C/MinGW/lib/libfile.a."

Henrik, can you elaborate on this? If this really is needed in this document, it would be good to move it somewhere other than a footnote...

-Chris

From: Chris Lattner Date: Wed, 9 Feb 2005 15:11:44 -0600 (CST)

Here is my first try to document, how to build the llvm suite for MinGW.

The GettingStarted patch looks fine to me, and I've applied it here:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20050207/023986.html

The other patch does not look ok. In particular, it would be much better to submit patches to make MinGW work as much like other platforms as possible. In particular, instead of telling the user to patch their sources and pass funny flags into make, it would be better to apply the patch to mainline CVS and fix the makefiles. :slight_smile:

Actually, looking closer, I think that some of the content added to the GettingStarted.html file should be moved to the HowToBuildTheCFE document. Specifically I'm thinking of:

"If you want to compile the C/C++ frontend, then upgrade to texinfo-4.5+ from source." ... so I removed it.

OK, I'll put the text there. I'll take a closer look later.

Also, I'm not sure what this is needed for:

"If you need to create a library for an MS DLL, do the following:

   1. pexports /C/WINNT/SYSTEM32/file.dll | sed "s/^_//" > /C/MinGW/lib/file.def
   2. Edit file and append @<ordinal> to the missing function name
   3. dlltool.exe -k -d /C/MinGW/lib/file.def -l /C/MinGW/lib/libfile.a."

It took me a while to find out how to generate missing libraries for windows dll's on MinGW. And unfortunately no one didn't/couldn't tell me how to do it. I guess someone would be in the same situation. But, I assume future versions of MinGW will support the psapi.dll and dbghelp.dll.

Henrik, can you elaborate on this? If this really is needed in this document, it would be good to move it somewhere other than a footnote...

I agree, do you have any suggestion?

Henrik.

How about the programmer's manual? It seems like just a general hint for using mingw, not LLVM specific at all. Should I remove the comment from the GSG?

-Chris

From: Chris Lattner Date: Wed, 9 Feb 2005 15:54:16 -0600 (CST)

How about the programmer's manual? It seems like just a general hint for using mingw, not LLVM specific at all. Should I remove the comment from the GSG?

Please remove the comment from the GSG. I'll take a look at the programmer's manual.

Henrik.