Policy for applying fixes to released branches?

Hi,

I was wondering what the policy is for applying fixes to released branches.

In particular I have fix that would be useful to have in LLVM 3.5. I
recently found and fixed a bug [1] in the way CMake files are
generated by the Autoconf/Makefile system and fixed this in r217484.

I figured it would be more sensible to ask about this in a thread
separate from [2] because this is a much more general question.

So what should I do here?

Should I also commit this patch to the branches/release_35 or am I not
allowed to do this and instead should downstream (e.g. Debian, Arch..
etc) just apply the patch when building their packages?

Even if I add the patch to the release branch I don't think most
distributions will get it because they'll probably use the tarballs
which won't have the patch. I'm pretty sure it would be unhelpful
rebuild the tarballs because downstream won't know that they need to
rebuild their packages.

@Sylvestre : IIRC you maintain LLVM Debian packages so I figured your
insight would be helpful.

[1] http://llvm.org/bugs/show_bug.cgi?id=20884
[2] http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-September/076573.html

Thanks,
Dan.

Hi there,

My guess is that such a patch should go into a new dot release becoming 3.5.1

According to [1], new releases get decided on by the 'release manager', I'm not sure who's the current person to contact for that. Maybe that's something we can document somewhere, I tried a quick search on the mailinglist but couldn't find it yet.

Cheers,
  Roel

[1] http://llvm.org/docs/HowToReleaseLLVM.html

Tom Stellard did the previous 3.4.2 release. I'm not sure if he plans
on doing any 3.5.x releases.

It maybe a bit early to do a 3.5.1 release though.

We have one branch per point release, and we tag each micro release:
http://llvm.org/viewvc/llvm-project/llvm/branches/

http://llvm.org/viewvc/llvm-project/llvm/tags/

Although I don’t see 3.4.1. =/

In that case, merging to the 3.5 release branch is the correct procedure to get it in 3.5.1.

Hi,

I was wondering what the policy is for applying fixes to released branches.

For 3.4.x, the policy was that release manager (me) was the only one who could commit patches to 3.4 branch. However, for 3.5, I would be in favor of allowing anyone to commit patches as long as they meet the normal criteria, which is:
1. Approval from code owner
2. Approval from release manager
3. No shared library ABI/API breakages

In particular I have fix that would be useful to have in LLVM 3.5. I
recently found and fixed a bug [1] in the way CMake files are
generated by the Autoconf/Makefile system and fixed this in r217484.

If you cc me on the commit email, I will take a look an approve it.

-Tom

Hi there,

My guess is that such a patch should go into a new dot release becoming
3.5.1

According to [1], new releases get decided on by the 'release manager', I'm
not sure who's the current person to contact for that.

Tom Stellard did the previous 3.4.2 release. I'm not sure if he plans
on doing any 3.5.x releases.

I am planning on doing 3.5.x releases.

-Tom

We have one branch per point release, and we tag each micro release:
http://llvm.org/viewvc/llvm-project/llvm/branches/
http://llvm.org/viewvc/llvm-project/llvm/tags/

Although I don't see 3.4.1. =/

The 3.4.1 tag is in the RELEASE_34 tag directory, we moved to the new tag names starting with 3.4.2.

-Tom

If you cc me on the commit email, I will take a look an approve it.

Okay I'll do this now.