Policy for updating tests in test-suite

Project Infrastructure LLVM Dev List Archives
1

Hi

Recently I found a bug in llvm-test-suite and I submitted a patch to fix it. The patch (https://reviews.llvm.org/D60039) is under review, but nobody is the owner of the test suite. Does anybody know the policy to update tests in llvm-test-suite?

Thanks

Yuanke

2

Hi Yuanke,

I’m not sure if any policy about this is written up anywhere, but in the past we have fixed other correctness bugs in the test-suite.
Even more, we have also made changes that weren’t fixing correctness issues, resulting in different benchmark numbers being produced.
Because of this, different revisions of the test-suite already can result in different correctness or benchmark results.

So, I don’t see good reasons not to fix a correctness bug.

Thanks,

Kristof