Possible LiveIntervals bug

At line 1155 of LiveIntervalAnalysis.cpp (in
LiveIntervals::rewriteInstructionsForSpills), should the condition

if (ImpUse && MI != ReMatDefMI && MI != ReMatOrigDefMI)

instead of:

if (ImpUse && MI != ReMatDefMI)


After all, ReMatDefMI is a clone of the original def instruction
(ReMatOrigDefMI). I'm seeing bad things happen, with intervals
getting HUGE_VALF set as their weight because they happen to
be used in RegMatOrigDefMI and MI doesn't match ReMatDefMI
(because it's a clone and not really in the IR at all!).


Yes, you are probably right.