Process for making LLVM changes?

Hi all,

I have a lldb patch I'm working on that requires changes to the LLVM code. I was wondering what the general procedure is for doing stuff like this; do I just submit my changes to the LLVM mainline first, and then submit an lldb patch? I don't want to be in a situation where lldb has a patch approved but it got rejected from LLVM...

Is lldb tied to a specific LLVM revision or are developers generally expected to have latest?

Thanks,

Hi all,

I have a lldb patch I'm working on that requires changes to the LLVM code. I was wondering what the general procedure is for doing stuff like this; do I just submit my changes to the LLVM mainline first, and then submit an lldb patch? I don't want to be in a situation where lldb has a patch approved but it got rejected from LLVM...

Get the LLVM patch approved and submitted first, then submit the LLDB changes.

Is lldb tied to a specific LLVM revision or are developers generally expected to have latest?

The latest top of tree llvm and clang is what we all use for development.

Hi Richard, welcome!

LLDB is not pinned to any specific LLVM/Clang revision (anymore) -- It's recommended to stay at (or around) trunk for all repos.

If you have patches with dependencies on other patches, just be explicit about the dependency when you post them for review. When they get committed, the dependency just has to be observed.

If your patches are non-trivial, you can make them easier to review (and test) by posting them on llvm-reviews.chandlerc.com! If you use that tool posting to the list can be streamlined by adding the mailing list (lldb-commits or llvm-commits) to the CC field when you submit the review request.

Good luck,
Dan

Awesome, thank you!