Proposed patches for Android Build errors

Project Infrastructure LLVM Dev List Archives
#1

Hi,
I'm sending two proposed patches to avoid building errors in llvm70 master

With you compiler/buildchain you may not see these errors,
but they are happening with Android Build System (oreo-x86 based on 8.1.0_r18)

Please review and correct them if needed

Mauro Rossi
android-x86 team

[PATCH 1/2] AMDGPU/SIInsertWaitcnts: Fix comparison of integers of diff signs
[PATCH 2/2] Object/WasmObjectFile: Fix comparison of different signs

#2

Fixes the following building error:

external/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1903:61:
error: comparison of integers of different signs:
'typename iterator_traits<__wrap_iter<MachineBasicBlock **> >::difference_type'
(aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
                      BlockWaitcntProcessedSet.end(), &MBB) < Count)) {
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~
1 error generated.

Fixes: 4f520606fc ("[AMDGPU] Do not only rely on BB number when finding bottom loop")

#3

Fixes the following building error:

external/llvm/lib/Object/WasmObjectFile.cpp:978:14:
error: comparison of integers of different signs:
'uint32_t' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
    if (Size > Ctx.End - Ctx.Ptr)
        ~~~~ ^ ~~~~~~~~~~~~~~~~~
1 error generated.

Fixes: 50617cfe72 ("[WebAssembly] Add more error checking to object file parsing")

#4

Hi Mauro,

the more common process is to do reviews via Phabricator. In any case, patch #1 looks good to me. Do you have commit access?

Cheers,
Nicolai