Hi all,
tldr; Please update all of your API usages of Identifier to StringAttr.
Just a heads up that Identifier is in the process of being removed in favor of StringAttr. StringAttr essentially provides the same API and functionality as Identifier, and unifying the two allows for reducing some complexity/additional uniquing/etc. in the ecosystem. If you have any usages of Identifier::getDialect, please make sure to update that to StringAttr::getReferencedDialect, StringAttr::getDialect means something different and can result in errors during compilation (i.e. this will not be caught at build time!). I’ll leave the Identifier typedef in-tree for 2-3 weeks to give folks time to upgrade before doing a full delete.
– River