Question about ExpandPostRAPseudos.cpp

Project Infrastructure LLVM Dev List Archives
#1

When trying to run test/CodeGen/X86/liveness-local-regalloc.ll with the command line options “-optimize-regalloc=0 –verify-machineinstrs –mcpu-atom”, the test fails right after the Post-RA pseudo instruction pass with the messages

*** Bad machine code: Using an undefined physical register ***

  • function: autogen_SD24657

  • basic block: BB 0x2662d60 (BB#0)

  • instruction: %XMM0 = MOV64toPQIrr %RAX

  • operand 1: %RAX

LLVM ERROR: Found 1 machine code errors.

This happens because, on entry to the pass, we have

%RAX = SUBREG_TO_REG 0, %R9D, 4

%XMM0 = MOV64toPQIrr %RAX

The pass converts (around about line 132 in ExpandPostRAPseudos.cpp) the SUBREG_TO_REG pseudo op to

%EAX = MOV32rr %R9D

Because of “-mcpu-atom”, post RA scheduling is enabled, so is post RA liveness tracking. Because the destination has been changed to EAX from RAX in transforming the SUBREG_TO_REG pseudo op into a MOV32rr, liveness checking fails in MachineVerifier.cpp.

Would anyone be able to comment on why the SUBREG_TO_REG conversion changes the destination register and/or to suggest how this problem might best be fixed?

Thanks!

Preston

#2

The SUBREG_TO_REG instruction is like a copy, but it is asserting that the high part of the register was cleared by the defining instruction.

It is normally coalesced away by the optimizing register allocator pipeline, but it can sometimes survive to ExpandPostRAPseudos. The def of %RAX should have been preserved as an implicit def operand on the copy:

               %EAX<def> = MOV32rr %R9D, %RAX<imp-def>

It looks like LowerSubregToReg() needs to Copy->addRegisterDefined(DstReg).

/jakob