r260758 broke windows build

Hello,

I suspect that r260758 by kparzysz@codeaurora.org broke build the
windows bots which are using Visual Studio 2013 or lower. This doc
here specifies that the minimum version required is VS-2013:

http://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library

I do see that the bots running VS-2014 or higher are green.

Can we either revert the said commit or fix it?

I work on LLDB and our windows bot is red with build step failing:
http://lab.llvm.org:8011/builders/lldb-windows7-android

Thank you,
Siva Chandra

I'll try it locally, but in the meantime, could you send me the preprocessed file from your build?

-Krzysztof

It works for me:

------ Build started: Project: LLVMHexagonCodeGen, Configuration: RelWithDebInfo Win32 ------
cl : Command line warning D9002: ignoring unknown option '/Zc:inline'
   HexagonFrameLowering.cpp
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

Here's the info from the "about" window:

   Microsoft Visual Studio Professional 2013
   Version 12.0.21005.1 REL
   Microsoft .NET Framework
   Version 4.6.01055

   Installed Version: Professional

Here's what it showed during cmake:

c:\"Program Files (x86)"\CMake\bin\cmake -G "Visual Studio 12" /m -DLLVM_TARGETS_TO_BUILD:STRING=All" "-DLLVM_BUILD_RUNTIME:BOOL=OFF" "-DCMAKE_SKIP_INSTALL_ALL_DEPENDENCY:BOOL=ON" "-DLIBCLANG_BUILD_STATIC=ON" "-DLLVM_USE_MC_TOOLS:STRING=yes" "-DLLVM_ENABLE_PIC:BOOL=ON" "-DLLVM_ENABLE_ASSERTIONS:BOOL=ON" "-DWITH_POLLY:BOOL=OFF" "-DLLVM_BUILD_RUNTIME:BOOL=OFF" "-DCMAKE_BUILD_TYPE=RelWithDebInfo" "..\llvm\llvm.org"
-- Building for: Visual Studio 12 2013
-- The C compiler identification is MSVC 18.0.21005.1
-- The CXX compiler identification is MSVC 18.0.21005.1

-Krzysztof

Are you building LLDB? Im guessing that is where the failure is

I'm building LLVM. The failure in the buildbot happens when compiling HexagonFrameLowering.cpp:

Appeased in r260812.

Thank you very much good sir!

-Krzysztof

It has been fixed by
http://llvm.org/viewvc/llvm-project?revision=260812&view=revision

Thank you,
Siva Chandra