r300964 and the llvm-clang-x86_64-expensive-checks-win buildbot

Hi,

One of my commits earlier today (r300964) is causing llvm-clang-x86_64-expensive-checks-win to fail with a compilation error (http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1331) and I’m having trouble figuring out why. I had seen something similar before on MSVC so I tried fixing it in r300966 but with no luck. I then managed to reproduce it using an online MSVC compiler and fixed that issue in r300970 but still no luck. I’m going to revert the commit to make the bot green while I figure it out but I don’t have a MSVC environment at the moment so I was wondering if anyone who does can reproduce the problem and tell me what it is that MSVC doesn’t like.

Thanks

For reasons I’m not sure about it needs a clean build every so often - I’ve forced a build at http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1341 and its gone green again.

clean buld forced the regeneration of X86GenGlobalISel.inc & AArch64GenGlobalISel.inc, which may have not happened otherwise.

‫בתאריך יום ו׳, 21 באפר׳ 2017 ב-18:29 מאת ‪Simon Pilgrim via llvm-dev‬‏ <‪llvm-dev@lists.llvm.org‬‏>:‬

clean buld forced the regeneration of X86GenGlobalISel.inc & AArch64GenGlobalISel.inc, which may have not happened otherwise.

Thanks, I think that’s the problem. I can see the tablegen commands in #1341 but they aren’t in #1331 or #1340.

I’ll re-land this commit and we’ll see if a clean build makes it work properly.

‫בתאריך יום ו׳, 21 באפר׳ 2017 ב-18:29 מאת ‪Simon Pilgrim via llvm-dev‬‏ <‪llvm-dev@lists.llvm.org‬‏>:‬

For reasons I’m not sure about it needs a clean build every so often - I’ve forced a build at http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1341 and its gone green again.

Thanks. My revert landed in http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1340 but it continued to fail so I was very confused.

Is forcing a clean build something I can do from the buildbot interface? I’ve got a few patches to commit that are likely to trigger this problem.

The re-commit is r300993.

Hello Daniel,

Is forcing a clean build something I can do from the buildbot interface? I’ve got a few patches to commit that are likely to trigger this problem.

There are 2 possible ways to do so:

  1. You can force a clean build from the buildbot WebUI by specifying a property ‘clean’ with the value ‘True’ (http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win, “Property 1 Name:” filed is ‘clean’ and the corresponding “Value:” field is ‘True’, then click the “Force Build” button.)

  2. If you know in advance that your commit requires a clean build, you may add something like “Requires a clean build.” somewhere in the commit message. That would trigger clean builds.

Not all builders support this, though. The llvm-clang-x86_64-expensive-checks-win buildbot does. I’m in the middle of expanding these features to the rest of the builders.

As of the original issue, it seems those inc files are missing dependencies. I’ll look into this.

Thanks

Galina

Thanks. I forced a clean build in http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/1353 and it’s now green.