r329889 - Use in-tree dsymutil on Darwin

r329889 says "Use in-tree dsymutil on Darwin", but it's got these change in
test/CMakeLists.txt:
-set(LLDB_TEST_DEPS lldb)
+set(LLDB_TEST_DEPS lldb dsymutil)

...

+ --dsymutil $<TARGET_FILE:dsymutil>

These changes aren't gated by a check for Darwin, so they happen on all
systems. On my machine (Ubuntu 14), which doesn't have dsymutil, cmake
generation gives errors about missing dependency dsymutil.

CMake Error at tools/lldb/test/CMakeLists.txt:161 (add_dependencies):
   The dependency target "dsymutil" of target "lldb-dotest" does not exist.

Jonas, can you gate those changes with a check for Darwin, which is the
intention of the patch?

Ted

r329889 says "Use in-tree dsymutil on Darwin", but it's got these change

in

test/CMakeLists.txt:
-set(LLDB_TEST_DEPS lldb)
+set(LLDB_TEST_DEPS lldb dsymutil)

Shouldn't this just be llvm-dsymutil, which should be always present
(except standalone builds, I guess)?

Hi Ted,

I tried to reproduce this issue over the weekend on a Linux machine, but to no success.

r329889 says "Use in-tree dsymutil on Darwin", but it's got these change in
test/CMakeLists.txt:
-set(LLDB_TEST_DEPS lldb)
+set(LLDB_TEST_DEPS lldb dsymutil)

...

+ --dsymutil $<TARGET_FILE:dsymutil>

These changes aren't gated by a check for Darwin, so they happen on all
systems. On my machine (Ubuntu 14), which doesn't have dsymutil, cmake
generation gives errors about missing dependency dsymutil.

As dsymutil is an LLVM target, it should be available regardless of the host machine. That is, as Pavel noted, unless you’re doing a standalone build. Any chance this is the case?

CMake Error at tools/lldb/test/CMakeLists.txt:161 (add_dependencies):
  The dependency target "dsymutil" of target "lldb-dotest" does not exist.

Jonas, can you gate those changes with a check for Darwin, which is the
intention of the patch?

I’ve changed the configuration to only add the dependency when not doing a stand-alone built in r330568. Please let me know if that works for you.

Ted

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project

_______________________________________________
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev

...

r329889 says "Use in-tree dsymutil on Darwin", but it's got these change

in

test/CMakeLists.txt:
-set(LLDB_TEST_DEPS lldb)
+set(LLDB_TEST_DEPS lldb dsymutil)

Shouldn't this just be llvm-dsymutil, which should be always present
(except standalone builds, I guess)?

I renamed llvm-dsymutil to just dsymutil a while ago because we’ve upstreamed almost everything (only support for BCSymbolMaps is missing, which I’m in the progress of upstreaming).