I apologize that my two patches "Remove trailing space" (r338291 in clang, r338293 in llvm)
are committed without a discussion happening within the community.
Forward to llvm-dev and cfe-dev to see if they are what the community would like to see committed or not.
The original discussion is at this thread
I'd prefer not reverting too. We've already had to deal with the
conflict and reverting would just repeat it, without fixing blame.
- Please do not revert this change.
I found out that reverting wouldn't help the situation I was worried about
anyway, the damage was already done. Thankfully, the merge conflicts
haven't been too awful.
- Please avoid committing trailing whitespace in the first place. If
that's not already a rule in LLVM's style, let's add it.
- In the future, please do not commit massive formatting changes to files
that you are not otherwise editing.
- If you are editing a file and you find it convenient to reformat it,
please do it separately before you send your code for review to avoid
obscuring your changes.
+1 to all of this. I will be proposing some edits to the developer policy
to make this more clear for folks in the future.
Thank you, everyone, for the discussion on this – I’ve put up a review at https://reviews.llvm.org/D50055 for the coding standard changes, if you’re interested.