Recently failing vector tests

Project Infrastructure LLVM Dev List Archives
1

Running on x86-64 linux:

FAIL: test/CodeGen/X86/vec_ins_extract.ll
Failed with exit(1) at line 1
while running: llvm-as < test/CodeGen/X86/vec_ins_extract.ll | opt -scalarrepl -instcombine | llc -march=x86 -mcpu=yonah | not grep sub.*esp
        subl $16, %esp
        subl $16, %esp
        subl $16, %esp
        subl $16, %esp
child process exited abnormally
FAIL: test/CodeGen/X86/vec_shuffle-10.ll
Failed with exit(1) at line 3
while running: llvm-as < test/CodeGen/X86/vec_shuffle-10.ll | llc -march=x86 -mattr=+sse2 | not grep {sub.*esp}
        subl $16, %esp
        subl $16, %esp
child process exited abnormally

Any ideas?

Ciao,

Duncan.

2

Is the code actually loading and storing to the stack, or just allocating space?
If the latter it is probably this patch:
http://llvm.org/viewvc/llvm-project?view=rev&revision=52750

Rounding up the stack size does not have to be done if there are no stack
objects, so that would be the preferred way to fix this. See if this works for you.
It will be something close to this.

Index: CodeGen/PrologEpilogInserter.cpp

3

Hi Dale, yes it's just stack alignment. Unfortunately
your patch doesn't make any difference.

Thanks for thinking about this,

Duncan.

4

Hi Dale, yes it's just stack alignment. Unfortunately
your patch doesn't make any difference.

Thanks for thinking about this,

Duncan.

OK, the test is not quite right then. This doesn't happen on Darwin so I'm
afraid you'll have to debug it. Perhaps testing for
        (RegInfo->needsStackRealignment(Fn) &&
         FFI->getObjectIndexEnd()!=0)
?

5

Hi Dale,

OK, the test is not quite right then. This doesn't happen on Darwin
so I'm
afraid you'll have to debug it. Perhaps testing for
        (RegInfo->needsStackRealignment(Fn) &&
         FFI->getObjectIndexEnd()!=0)
?

yes, that works - thanks! Since I have no idea what this is
doing, is it ok if I leave it to you to commit it?

Thanks again,

Duncan.

6

Hi Dale,

OK, the test is not quite right then. This doesn't happen on Darwin
so I'm
afraid you'll have to debug it. Perhaps testing for
       (RegInfo->needsStackRealignment(Fn) &&
        FFI->getObjectIndexEnd()!=0)
?

yes, that works - thanks! Since I have no idea what this is
doing, is it ok if I leave it to you to commit it?

Thanks again,

Duncan.

OK, I'll test that for Darwin and commit.