Restarting a stalled patch

Hello,

I was curious if there was any advice on how to get a code-review restarted/completed. The two I’ve submitted recently (D30107 D29923) have gotten a bit of review but both then seem to stall. Any hints?

Thanks.

Standard practice is to add a comment yourself that says “Ping” (people don’t mind a pace of about 1/week, more if it is particularly urgent).

http://llvm.org/docs/DeveloperPolicy.html#code-reviews

–paulr

Thanks. I have gone that route and there was no response.

What constitutes ‘particularly urgent’?

In regards to D30107 it some fairly obvious defect(s) and there are a few bugs open in your database about the issue,

but it seems an area that doesn’t get much interest (related to DynamicLibrary class).

Thanks again.

Thanks. I have gone that route and there was no response.

Well, I see you pinged D30107 and there were some comments yesterday.
I don't see a ping on D29923 until today. Even with a ping, it can
take a while. Not to discourage you, but I have known patches to
sit for months waiting for review.

What constitutes 'particularly urgent'?

I'd say, something that is blocking your other work until it is
resolved, or otherwise has a serious impact on you or your users
(if you are providing something to others).

In regards to D30107 it some fairly obvious defect(s) and there are a
few bugs open in your database about the issue,

If there are open bugs that you are fixing, it's generally a good idea
to mention which ones in the summary. You could also post a reply to
the bug pointing to the relevant review(s), which will notify the
people who filed the bug or cc'd themselves to it. This is not to say
that they will necessarily want to review it, but it's worth doing.

but it seems an area that doesn't get much interest (related to
DynamicLibrary class).

I sympathize; it can be very hard to get reviews for changes to the
more obscure (or less interesting) parts of the code base.

Thanks again.

You're welcome. I promise you I have been where you are!
--paulr

Ughs, I’m not dying to wait months…but if it thats the way it is, then its the way it is.

Tends to be so many commits in a day it seemed it was being lost in the noise/clique.

I did try to add some notes to the bug tracker, but new logins are disabled, and the

email to get one never replied…but I guess that’s another topic!

Thanks again, definitely alleviated some frustrations.

In general, we try not to have it take months. Sometimes people go on vacation or just get really busy for a week or two. Development is active, but for some components, the number of people really familiar with them is small. In my experience, just keep pinging, and either the person reviewing will get back to you, or we can find someone else to pick it up. Finding the code owner, if there is one, is also a good bet. The job of a code owner is to be reviewer of last resort (or to find someone) - see the CODE_OWNERS.TXT file. I’ll follow-up for you. Â -Hal

Was added, thanks!