[RFC] better link error messages

Project Infrastructure LLVM Dev List Archives
#21

My bad. I intended this.

Undefined symbol error:

bin/ld.lld: error: undefined symbol: lld::elf::EhFrameSection<llvm::object::ELFType<(llvm::support::endianness)0, true>
>>> Referenced by Writer.cpp:207 (/ssd/llvm-project/lld/ELF/Writer.cpp:207)
>>> Writer.cpp.o in archive lib/liblldELF.a

Duplicate symbol error:

bin/ld.lld: error: duplicate symbol: lld::elf::MipsGotSection::addEntry(lld::elf::SymbolBody&, long, lld::elf::RelExpr)
>>> defined at Writer.cpp:38 (/home/buildslave/buildslave/clang-cmake-aarch64-39vma/llvm/tools/lld/ELF/Writer.cpp:38)
>>> Writer.cpp.o in archive lib/liblldELF.a
>>> defined at SyntheticSections.cpp:673 (/home/buildslave/buildslave/clang-cmake-aarch64-39vma/llvm/tools/lld/ELF/SyntheticSections.cpp:673)
>>> SyntheticSections.cpp.o in archive lib/liblldELF.a

#22

I am late on the thread, but I just want to say that the new format
looks awesome!

Thanks,
Rafael

#23

The first patch is sent out: https://reviews.llvm.org/D31481

#24

Hi guys,

I submitted https://reviews.llvm.org/rL299097 and https://reviews.llvm.org/rLr299280 to change the error message styles for undefined or duplicated symbols.

I want to get stable error message formats until the next LLVM release, but until then, we can change them freely. So you don’t need to think that they are in the final form. I’ll try to use this to see if further changes are needed. If you are interested, please do that yourself too.

Thanks,
Rui

#25

Thanks for the work. The current error messages are much better.

Cheers,
Rafael