[RFC] Listing files in remote directory

Hello everyone,

To implement a remote disk file completion like CommandCompletions:DiskFilesOrDirectories for commands like "platform get-size”, I was trying to find out how local disk files are resolved. It seems the resolving mechanism is based on the llvm::sys module with which the implementation of CommandCompletions:DiskFilesOrDirectories is indirectly coupled.

As I went through the DoExecute function of platform commands, it seems the remote context can be accessed by the Platform pointer returned from CommandObject::GetDebugger().GetPlatformList().GetSelectedPlatform(). So maybe we could refactor CommandCompletions:DiskFilesOrDirectories into Platform:: DiskFilesOrDirectories to make it available for remote resolving?

But I don’t know if the idea above is right or feasible. Or maybe there could be other better solutions.

Does anyone have ideas?

Best regards,
Gongyu Deng

Hello everyone,

To implement a remote disk file completion like CommandCompletions:DiskFilesOrDirectories for commands like "platform get-size”, I was trying to find out how local disk files are resolved. It seems the resolving mechanism is based on the llvm::sys module with which the implementation of CommandCompletions:DiskFilesOrDirectories is indirectly coupled.

As I went through the DoExecute function of platform commands, it seems the remote context can be accessed by the Platform pointer returned from CommandObject::GetDebugger().GetPlatformList().GetSelectedPlatform(). So maybe we could refactor CommandCompletions:DiskFilesOrDirectories into Platform:: DiskFilesOrDirectories to make it available for remote resolving?

But I don’t know if the idea above is right or feasible. Or maybe there could be other better solutions.

Does anyone have ideas?

That can be tricky, but it can be made to work. The main issue we have to worry about is sometimes file completion will want to be local, and sometimes we will want to use the platform. For example the “target create” command probably wants to use local paths, and other commands might want the platform. It would be interesting to see all of the places this completion is used and see if we can easily classify them into local or platform, or some might want both?

It would be easy to move the llvm::sys file system calls into the host platform code if we were to make this happen.

Greg

I think classifying into local/platform isn’t an issue (I think we always know if we’re doing remote or local completion), but the bigger problem is that I’m not sure if we can easily list files/subdirs in a remote directory. I didn’t find any existing functionality that’s doing this, so I guess that would require to implement this functionality from scratch. And the problem with that is that I’m not even sure which underlying protocols support this functionality (without complicated workarounds at least), so that seems quite a lot of work.

  • Raphael

We only really have one remote protocol -- gdb-remote. And we haven't
shied from introducing extensions to it in the past, so I don't see why
we couldn't add one for remote tab-completion.

I don't think that should be a lot of work -- the code for tab
completion is already there, so it should mostly be a matter of plumbing
the request through the gdb-remote classes. I think that could be useful
at times -- I find the ssh remote tab completion in bash pretty useful.

That said, it's quite possible there are other tab-completion-y things
that could be done and which have a better cost-benefit ratio.

pl