mplatings:
I’ve realised that the example in ⚙ D143587 [Docs] Multilib design misses out that you can do Flags: fc++abi=itanium
in the Variants
list, you don’t need to use FlagMap
. I apologise for not making this clearer and I’ve updated the patch to make it more apparent.
FlagMap
is specifically intended for more complex cases that you want either negation or to map many possible Clang-generated flags onto another flag. Given that specific intention, I think the additional power of a regular expression is appropriate. Nevertheless I’m open to switching to the more verbose option, particularly if we start to see problems like those in sanitizer files.
Does this mean that you can do the following?
Variants:
- Dir: itanium
Tags: [fc++abi=itanium]
PrintOptions: [-fc++abi=itanium]
If that’s the case then I think the original name “flags” is a better fit than “tags”. I apologize about going back on forth on this. It might be also worth including this example in the documentation.