[RFC] Propose David Blaikie as a code owner for Clang debug info

Eric Christopher (@echristo) is listed as the code owner for Clang debug info. I asked him if he wanted to pass on the mantle to David Blaikie (@dblaikie), and David said he was willing to take that on. Other notable contributors to debug info are @pogo59 , @JDevlieghere , and @adrian.prantl .

Are folks in agreement that David is the right owner for debug info in clang? I have spoken to several community members, and people tell me that they really appreciate his helpful and thorough code review.

13 Likes

Sounds good to me, @dblaikie provides invaluable feedback and is very much the expert in this area!

3 Likes

I’m 100% in support of @dblaikie becoming a code owner for debug info. But for clarity, does @echristo want to remain a code owner as well? Having multiple code owners is something we’re doing these days in Clang and there’s a lot of benefits to that model, so that might be a good option if David and Eric are comfortable with such an arrangement. (Not trying to pressure anyone, it’s also totally fine if we continue to have a solo owner here.)

2 Likes

Thank you for proposing @dblaikie and thank you @dblaikie for agreeing to do this! I support that nomination.

1 Like

Overdue recognition of his de-facto role, I’m all for it.

1 Like

I’m supportive of Dave becoming the new code owner. Unless there’s objection to having multiple code owners [1], I would like to nominate @adrian.prantl to complement to Dave on the Apple side of things (e.g. Objective-C, gmodules, etc). Adrian wrote most of that code anyway and like Dave has been an active reviewer.

[1] I personally really like this idea. I was inspired by @AaronBallman’s work in this space for clang and started working on a RFC to bring that model to LLDB (whose code owners are horribly outdated). I hope to publish that soon.

4 Likes

I happily support this nomination assuming @adrian.prantl is okay taking on the role and @dblaikie is comfortable with the arrangement.

That’s fantastic, thank you for working to refresh the code owners for lldb!

1 Like

I like the idea of sharing the responsibility. I’m happy to accept the nomination.

4 Likes

I think sharing the role is an excellent idea, and Adrian is exactly the right person for it.

1 Like

@rnk is there a reason this is only for Clang debug info, and not LLVM debug info also? Because of the way the project is split up, code ownership is maintained separately, but it makes more sense to have the owners be the same for both projects.

1 Like

Unless there’s objection to having multiple code owners [1], I would like to nominate @adrian.prantl to complement to Dave on the Apple side of things (e.g. Objective-C, gmodules, etc). Adrian wrote most of that code anyway and like Dave has been an active reviewer.

Sounds good to me too!

+1 consider adding more than one owner so that we can raise the bus factor

I’ll stick around, I do still pay attention, but Dave and the others are faster than I am these days and I’m not as active as I was in the area :slight_smile:

-eric

On Thu, Jul 20, 2023 at 7:15 AM Aaron Ballman via LLVM Discussion Forums <notifications@llvm.discoursemail.com> wrote:

AaronBallman
July 20

I’m 100% in support of @dblaikie becoming a code owner for debug info. But for clarity, does @echristo want to remain a code owner as well? Having multiple code owners is something we’re doing these days in Clang and there’s a lot of benefits to that model, so that might be a good option if David and Eric are comfortable with such an arrangement. (Not trying to pressure anyone, it’s also totally fine if we continue to have a solo owner here.)


Visit Topic or reply to this email to respond.

To unsubscribe from these emails, click here.

1 Like

Thank you for all your efforts as code owner here, they’re greatly appreciated! And big thanks to @dblaikie and @adrian.prantl for stepping up!

1 Like

I support Dave and Adrian as code owners, and in fact I’m pretty surprised that they weren’t officially in this role already.

1 Like

Thanks everyone! I think for some reason I had a mindset of “there must be one”, but that really isn’t necessary. I’ll make a patch.

Mainly because I’m just looking at the clang/CodeOwners.rst file. The other files need a deeper refresh.

2 Likes

Happy to formalize the ownership, and yeah, adding me & Adrian sounds good.

Thanks!

2 Likes

I see this has been committed. Congratulations and thank you @dblaikie & @adrian.prantl!

1 Like