Should ValueTracking::GetUnderlyingObject stop on Alloca instructions rather than calling SimplifyInstruction?

I notice that GetUnderlyingObject has a few checks, but alloca isn’t one of them. Then it fall backs to SimplifyInstruction which doesn’t know about alloca so falls back to just trying to constant fold it. This seems a little silly since I assume alloca can’t be constant folded. Should we just detect this early in GetUnderlyingObject and stop?


Yep. Makes sense to me. There’s nothing to simplify or constant-fold about an alloca.



Commited in r300118.