split-debug broken in lastest clang?

Clang Frontend
#1

Hi

I just updated clang (about an hour ago) and now my build is crashing (see trace below).

Seems to be related using split-debug.

Thanks, Noel

[CPT] o3tl/qa/compile-temporary.cxx
clang++: /media/noel/disk2/clang/llvm/tools/clang/lib/Driver/InputInfo.h:85: const char* clang::driver::InputInfo::getFilename() const: Assertion `isFilename() && “Invalid accessor.”’ failed.
Stack dump:
0. Program arguments: /home/noel/clang/inst/bin/clang++ -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 -DDBG_UTIL -DLINUX -DOSL_DEBUG_LEVEL=1 -DSAL_LOG_INFO -DSAL_LOG_WARN -DUNIX -DUNX -DX86_64 -D_DEBUG -D_GLIBCXX_DEBUG -D_PTHREADS -D_REENTRANT -fvisibility=hidden -Werror -Xclang -load -Xclang /home/noel/libo/compilerplugins/obj/plugin.so -Xclang -add-plugin -Xclang loplugin -fsyntax-only -ferror-limit=0 -Xclang -verify -Wall -Wno-missing-braces -Wnon-virtual-dtor -Wendif-labels -Wextra -Wundef -Wunreachable-code -Wunused-macros -finput-charset=UTF-8 -fmessage-length=0 -fno-common -pipe -ggnu-pubnames -Wimplicit-fallthrough -fvisibility-inlines-hidden -fstack-protector-strong -fPIC -Wshadow -Woverloaded-virtual -std=gnu++2a -DEXCEPTIONS_ON -fexceptions -O0 -fstrict-aliasing -fstrict-overflow -fno-inline -ggdb2 -gsplit-dwarf -Xclang -plugin-arg-loplugin -Xclang --unit-test-mode -DLIBO_INTERNAL_ONLY -c /home/noel/libo/o3tl/qa/compile-temporary.cxx -o /home/noel/libo/workdir/CxxObject/o3tl/qa/compile-temporary.o -I/home/noel/libo/include -I/usr/lib/jvm/java-10-openjdk-10.0.2.13-7.fc29.x86_64/include -I/usr/lib/jvm/java-10-openjdk-10.0.2.13-7.fc29.x86_64/include/linux -I/home/noel/libo/config_host

  1. Compilation construction
  2. Building compilation jobs
  3. Building compilation jobs
    #0 0x0000000001a9473c llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/home/noel/clang/inst/bin/clang+++0x1a9473c)
    #1 0x0000000001a92795 llvm::sys::RunSignalHandlers() (/home/noel/clang/inst/bin/clang+++0x1a92795)
    #2 0x0000000001a92905 SignalHandler(int) (/home/noel/clang/inst/bin/clang+++0x1a92905)
    #3 0x00007fa979238070 __restore_rt (/lib64/libpthread.so.0+0x13070)
    #4 0x00007fa978d0553f __GI_raise (/lib64/libc.so.6+0x3853f)
    #5 0x00007fa978cef895 __GI_abort (/lib64/libc.so.6+0x22895)
    #6 0x00007fa978cef769 _nl_load_domain.cold.0 (/lib64/libc.so.6+0x22769)
    #7 0x00007fa978cfd9f6 (/lib64/libc.so.6+0x309f6)
    #8 0x00000000022319e2 clang::driver::tools::SplitDebugName(llvm::opt::ArgList const&, clang::driver::InputInfo const&) (/home/noel/clang/inst/bin/clang+++0x22319e2)
    #9 0x00000000022278ac clang::driver::tools::Clang::ConstructJob(clang::driver::Compilation&, clang::driver::JobAction const&, clang::driver::InputInfo const&, llvm::SmallVector<clang::driver::InputInfo, 4u> const&, llvm::opt::ArgList const&, char const*) const (/home/noel/clang/inst/bin/clang+++0x22278ac)
    #10 0x00000000021d3269 clang::driver::Driver::BuildJobsForActionNoCache(clang::driver::Compilation&, clang::driver::Action const*, clang::driver::ToolChain const*, llvm::StringRef, bool, bool, char const*, std::map<std::pair<clang::driver::Action const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator > >, clang::driver::InputInfo, std::less<std::pair<clang::driver::Action const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator > > >, std::allocator<std::pair<std::pair<clang::driver::Action const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator > > const, clang::driver::InputInfo> > >&, clang::driver::Action::OffloadKind) const (/home/noel/clang/inst/bin/clang+++0x21d3269)
    #11 0x00000000021d540d clang::driver::Driver::BuildJobsForAction(clang::driver::Compilation&, clang::driver::Action const*, clang::driver::ToolChain const*, llvm::StringRef, bool, bool, char const*, std::map<std::pair<clang::driver::Action const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator > >, clang::driver::InputInfo, std::less<std::pair<clang::driver::Action const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator > > >, std::allocator<std::pair<std::pair<clang::driver::Action const*, std::__cxx11::basic_string<char, std::char_traits, std::allocator > > const, clang::driver::InputInfo> > >&, clang::driver::Action::OffloadKind) const (/home/noel/clang/inst/bin/clang+++0x21d540d)
    #12 0x00000000021d5ca6 clang::driver::Driver::BuildJobs(clang::driver::Compilation&) const (/home/noel/clang/inst/bin/clang+++0x21d5ca6)
    #13 0x00000000021d7b65 clang::driver::Driver::BuildCompilation(llvm::ArrayRef<char const*>) (/home/noel/clang/inst/bin/clang+++0x21d7b65)
    #14 0x00000000007c58c7 main (/home/noel/clang/inst/bin/clang+++0x7c58c7)
    #15 0x00007fa978cf1413 __libc_start_main (/lib64/libc.so.6+0x24413)
    #16 0x000000000081b9ce _start (/home/noel/clang/inst/bin/clang+++0x81b9ce)
    make[1]: *** [/home/noel/libo/solenv/gbuild/LinkTarget.mk:291: /home/noel/libo/workdir/CxxObject/o3tl/qa/compile-temporary.o] Aborted (core dumped)
    make[1]: *** Waiting for unfinished jobs…
    make: *** [Makefile:286: build] Error 2
#2

I do see the same problem, I was not able to bisect the issue yet. But the comment should have been within this day, do you have a more specific timeframe when the issue starts appearing?

#3

No, sorry, I last updated several weeks ago.

#4

I was able to bisect the problem, the issue is the following commit:
https://reviews.llvm.org/rL347035, reverting does resolve the problem.

On the page is my current investigation, it is related to having
`-gsplit-dwarf` in the compile-commands. I will revert the commit for now.

#5

thanks Jonas

#6

Hi Noel,

here is a potential patch for the issue:
https://reviews.llvm.org/D55006, could you try out if it does fix the
issue for you?

My builds do not suffer anymore. (Thanks grimar :))

Best, Jonas