Static analysis of Hyperion (llvm/clang)

Hi,

Just in case something interesting might turn up, I ran the llvm/clang static source code analyzer on a recent (latest ?) git revision of Hyperion.

For those who are interested, results can be found here :

https://home.kpn.nl/m.hoes73/scan-build/hyperion/

Surely they cant all be false positives.
:wink:

  • Maarten

OOps sorry, wrong list.

Please ignore.

  • Maarten

Only sort-of :slight_smile:

We would be interested in hearing about your results as you go through them!

Thanks!

-eric

Only sort-of :slight_smile:

We would be interested in hearing about your results as you go through them!

Yes!

Hi,

Only sort-of :slight_smile:

We would be interested in hearing about your results as you go through them!

Yes!

Well in that case, here we go…

Im not really a developer myself, but I am a user of that codebase and as I like the code I use to be as bug-free as possible, I was hoping to trigger the developers into looking at their code more closely. :wink:

Their first impression seem to be - and I guess this doesnt come as a surprise - that there are false positives, but also some real issues that need to be looked at. Also, there seems to be a template in use that has a variable that doesnt always get used/referenced, resulting in a spurious assignment. The reason it was written this way seems to be that it was assumed that the compiler would optimize the assignment out. So although those reports are valid, the code is not likely to get changed I guess.
(please forgive me for perhaps not making sense in the above, Im merely trying to summarize the responses on the right mailing list)

What I have personal experience with though, is that I ran into this bug during ./configure :
https://llvm.org/bugs/show_bug.cgi?id=25502
Perhaps that can be looked at ?

  • Maarten