StructRetPromotion and linkage

Project Infrastructure LLVM Dev List Archives
1

Hi all,

I was looking at the StructRetPromotion pass this morning and noticed it
doesn't look at a function's linkage at all. Since it changes the signature of
the function, I would say it should only change internal functions, like
ArgumentPromotion does for example.

Is there some implicit check I'm missing, or should an explicit check really
be added?

Gr.

Matthijs

2

I was looking at the StructRetPromotion pass this morning and noticed it
doesn't look at a function's linkage at all. Since it changes the signature of
the function, I would say it should only change internal functions, like
ArgumentPromotion does for example.

Is there some implicit check I'm missing, or should an explicit check really
be added?

It looks like the check was forgotten.

Ciao,

Duncan.

3

I added the missing check.