suspicious typo in MCObjectDisassembler.cpp

Project Infrastructure LLVM Dev List Archives
#1

my compiler gave me a warning in MCObjectDisassembler.cpp. it found a
self-comparation in loop condition. I think it's a typo.

the suspicious code was introduced by this patch:

#2

I believe you are correct. Fixed thusly:

dzur:~/sources/llvm> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M lib/MC/MCAnalysis/MCObjectDisassembler.cpp
Committed r214416

-eric

#3

Any chance of adding some missing test coverage here? That code was
dead (& evidently untested) before...

#4

I’m probably going to just remove it all. Message about that pending.

#5

Message sent, ack'd, and file removed.

-eric

#6

Hrm. It's apparently still used in llvm-objdump (and for some reason I
missed it in the build). So it's just untested :\

-eric