TargetInfo::CreateTargetInfo() takes owneship by reference

Clang Frontend
#1

Hi,

r165943 changed *TargetInfo::CreateTargetInfo() so that it takes ownership of TargetOptions &Opts which is passed by reference.

While it seems to me that it is not a good idea to take ownership from a reference in general (any guidelines about that in LLVM/Clang?), I feel it should be at least clearly stated in the comment before the function.

Best,

Mehdi

#2

Hi,

#3

Sorry for the delayed response. You're right that a pointer is better here; fixed in r168136.

  - Doug

#4

Does anyone care ? Client code like the one presented here: Basic source-to-source transformation with Clang - Eli Bendersky's website result in double-free corruption.

Sorry for the delayed response. You're right that a pointer is better here; fixed in r168136.

Thanks !

Mehdi