There are a bunch of tests in the tree that are named after Rdars. As a result, it’s not clear to anyone outside of Apple what these are supposed to be testing so it diminishes their usefulness and increases our maintenance burden since it’s impossible to know if it is an issue that we should fix, or if it is something platform specific.
Would it be possible for someone to rename these tests to something more descriptive?
Here is a list of some of the ones I’ve found:
lldb/test/functionalities/data_formatter:
-
rdar-3534688
-
rdar-9973865
-
rdar-9973992
-
rdar-9974002
-
rdar-10449092
-
rdar-10642615
-
rdar-10887661
-
rdar-11086338
-
rdar-11628688
-
rdar-11773899
-
rdar-11988289
-
rdar-12437442
-
rdar-12529957
-
rdar-13338477
lldb/test/python_api:
lldb/test/lang/cpp:
lldb/test/functionalities/command_script/import:
lldb/test/lang/objc:
-
rdar-9691614
-
rdar-10967107
-
rdar-11355592
-
rdar-12408181
For those tests which it is not possible to share more details about what the test is fixing, can I request those tests be moved out of tree? I assume Apple already has an internal test suite for this reason
There are a bunch of tests in the tree that are named after Rdars. As a result, it’s not clear to anyone outside of Apple what these are supposed to be testing so it diminishes their usefulness and increases our maintenance burden since it’s impossible to know if it is an issue that we should fix, or if it is something platform specific.
Would it be possible for someone to rename these tests to something more descriptive?
I think it’s a good idea (renaming the tests)
I can definitely take on some of the renaming effort
Here is a list of some of the ones I’ve found:
lldb/test/functionalities/data_formatter:
-
rdar-3534688
-
rdar-9973865
-
rdar-9973992
-
rdar-9974002
-
rdar-10449092
-
rdar-10642615
-
rdar-10887661
-
rdar-11086338
-
rdar-11628688
-
rdar-11773899
-
rdar-11988289
-
rdar-12437442
-
rdar-12529957
-
rdar-13338477
These are most certainly all of my own making…… sigh
lldb/test/python_api:
lldb/test/lang/cpp:
lldb/test/functionalities/command_script/import:
lldb/test/lang/objc:
-
rdar-9691614
-
rdar-10967107
-
rdar-11355592
-
rdar-12408181
For those tests which it is not possible to share more details about what the test is fixing, can I request those tests be moved out of tree?
Let us not do that if at all possible
Renaming is the correct avenue here
"If the test contents can be shared publicly, then so can a reasonable test name” seems a sane rule of thumb
I assume Apple already has an internal test suite for this reason
lldb-dev mailing list
lldb-dev@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
Thanks,
- Enrico
egranata@.com 
27683
There’s also test\expression_command\issue_11588, which is especially confusing because the comments and symbols in the test are actually numbered 11581.