TEXTREL usr/lib/llvm/libLLVM-3.0.so on PPC

Project Infrastructure LLVM Dev List Archives
1

Hi,

Can anyone fix this TEXTREL bug in ToT?
https://bugs.gentoo.org/show_bug.cgi?id=403519

Thanks,

2

Hello

Can anyone fix this TEXTREL bug in ToT?
403519 – sys-devel/llvm-3.0-r1 - TEXTREL usr/lib/llvm/libLLVM-3.0.so on PPC

The patch in PR is wrong since it will make both darwin and windows
unhappy. I will comment on gentoo PR about possible proper solution.

3

Kimura,

Can you please open an LLVM bug report for this, with a reference the
gentoo PR, so that this can be properly tracked from our end? Please
also add me to the CC list.

-Hal

4

Hi,

The patch in PR is wrong since it will make both darwin and windows
unhappy. I will comment on gentoo PR about possible proper solution.

I'll give it a try as you comment on the gentoo PR.
But my ppc box is in my office, so I'll post a result on next Monday (JST).

Thanks,

5

Hi,

Can you please open an LLVM bug report for this, with a reference the
gentoo PR, so that this can be properly tracked from our end? Please
also add me to the CC list.

I opened an LLVM bug report and added you to the CC list.
http://llvm.org/bugs/show_bug.cgi?id=12422

Thanks,

6

Hi,

The patch in PR is wrong since it will make both darwin and windows
unhappy. I will comment on gentoo PR about possible proper solution.

I'll give it a try as you comment on the gentoo PR.
But my ppc box is in my office, so I'll post a result on next Monday (JST).

I posted my result on the gentoo PR.
https://bugs.gentoo.org/show_bug.cgi?id=403519#c12
https://bugs.gentoo.org/show_bug.cgi?id=403519#c13
https://bugs.gentoo.org/show_bug.cgi?id=403519#c14

Thanks,

7

Hello

I posted my result on the gentoo PR.
403519 – sys-devel/llvm-3.0-r1 - TEXTREL usr/lib/llvm/libLLVM-3.0.so on PPC
403519 – sys-devel/llvm-3.0-r1 - TEXTREL usr/lib/llvm/libLLVM-3.0.so on PPC
403519 – sys-devel/llvm-3.0-r1 - TEXTREL usr/lib/llvm/libLLVM-3.0.so on PPC

I commented there. You need to declare function like

extern "C" {
static void* LLVM_ATTRIBUTE_USED
PPCCompilationCallbackC
<everything else goes here>
};

8

Hi,

You need to declare function like

extern "C" {
static void* LLVM_ATTRIBUTE_USED
PPCCompilationCallbackC
<everything else goes here>
};

revised patch is filed and it works fine.
https://bugs.gentoo.org/show_bug.cgi?id=403519#c16
https://bugs.gentoo.org/show_bug.cgi?id=403519#c17

so now this revised patch can be merged into ToT?

Thanks,

9

so now this revised patch can be merged into ToT?

Applied in r153938, thanks!