Hi!
Find attached 3 patches. I hope that this is the correct way to submit them
and that they are ok.
The first patch removes all header files for OpenMP 2.5.
The build will fail anyway since r219214 and an OpenMP-2.5 build was never
possible with CMake.
The second patch sets the Intel compiler as default when building for the
MIC without CMake (as it is already mentioned in the documentation).
It also fixes some tiny problems with the makefiles for the MIC.
Finally the third patch exports the common header files to exports/ with
CMake.
They should all apply independently and order shouldn't matter.
As I locally use git and extracted them with git format-patch, the commands
are:
$ patch -p1 <
0001-Remove-reference-to-OpenMP-2.5-in-build.pl-and-delet.patch
$ patch -p1 < 0002-Simplify-MIC-builds-without-CMake.patch
$ patch -p1 < 0003-CMake-Export-common-header-files.patch
As I fixed some issues with the old build.pl: Is this still used anymore?
Or will it get deleted in the near future, switching completely to CMake?
Cheers,
Jonas
0001-Remove-reference-to-OpenMP-2.5-in-build.pl-and-delet.patch (60.9 KB)
0002-Simplify-MIC-builds-without-CMake.patch (1.95 KB)
0003-CMake-Export-common-header-files.patch (809 Bytes)
Any comments on this? Or shall I put those on Phabricator as well?
Jonas
These patches look good to me. Thanks for the fixes and sorry for the silence.
We will integrate these very soon.
-- Johnny
Thanks as well!
As you committed my patches for build.pl, I suppose it is still needed and
used?
Jonas
From: Peyton, Jonathan L [mailto:jonathan.l.peyton@intel.com]
Sent: Wednesday, February 25, 2015 8:06 PM
To: Hahnfeld, Jonas
Subject: RE: Three patches
We have committed your patches.
Thanks again!
-- Johnny
From: openmp-dev-bounces@cs.uiuc.edu [mailto:openmp-dev-
bounces@cs.uiuc.edu] On Behalf Of Peyton, Jonathan L
Sent: Wednesday, February 18, 2015 12:37 PM
To: Hahnfeld, Jonas; openmp-dev@dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] Three patches
These patches look good to me. Thanks for the fixes and sorry for the
silence.
We will integrate these very soon.
-- Johnny
From: openmp-dev-bounces@cs.uiuc.edu [mailto:openmp-dev-
bounces@cs.uiuc.edu] On Behalf Of Hahnfeld, Jonas
Sent: Wednesday, February 18, 2015 1:14 AM
To: openmp-dev@dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] Three patches
Any comments on this? Or shall I put those on Phabricator as well?
Jonas
> From: openmp-dev-bounces@cs.uiuc.edu [mailto:openmp-dev-
> bounces@cs.uiuc.edu] On Behalf Of Hahnfeld, Jonas
> Sent: Thursday, February 05, 2015 10:27 AM
> To: openmp-dev@dcs-maillist2.engr.illinois.edu
> Subject: [Openmp-dev] Three patches
>
> Hi!
>
> Find attached 3 patches. I hope that this is the correct way to submit
> them and that they are ok.
>
> The first patch removes all header files for OpenMP 2.5.
> The build will fail anyway since r219214 and an OpenMP-2.5 build was
> never possible with CMake.
>
> The second patch sets the Intel compiler as default when building for
> the MIC without CMake (as it is already mentioned in the documentation).
> It also fixes some tiny problems with the makefiles for the MIC.
>
> Finally the third patch exports the common header files to exports/
> with CMake.
>
> They should all apply independently and order shouldn't matter.
> As I locally use git and extracted them with git format-patch, the
> commands
> are:
> $ patch -p1 <
> 0001-Remove-reference-to-OpenMP-2.5-in-build.pl-and-delet.patch
> $ patch -p1 < 0002-Simplify-MIC-builds-without-CMake.patch
> $ patch -p1 < 0003-CMake-Export-common-header-files.patch
>
> As I fixed some issues with the old build.pl: Is this still used
anymore?
> Or will it get deleted in the near future, switching completely to
CMake?
Right, internally we still use build.pl and do not use cmake for our builds (maybe just habit? But it is hard to get rid of convenient working tools...).
Regards,
Andrey