Turn off lint pre-merge checks for test/

Would it be possible to turn off the lint pre-merge checks for
the test/ folder? The suggestion to run clang-format on the tests
is not useful and adds a lot of noise to the diff.

Bruno Ricci

Would it be possible to turn off the lint pre-merge checks for
the test/ folder? The suggestion to run clang-format on the tests
is not useful and adds a lot of noise to the diff.

Strong +1. Same for running clang-tidy checks, etc.

~Aaron

Maybe it is time to add capability for a .clang-format-ignore file that can work across the tree, then those that want to turn them off could?

There are some areas where the tests are already clean. It would be a shame to not keep them so, but I understand that FileCheck sometimes might need comments with length that don’t meet the style guide

For now could you simply add a local .clang_format file in the test directory to turn clang-format off

e.g.

Some of the test folders already have .clang-format files which just
override the column limit

Maybe it is time to add capability for a .clang-format-ignore file that can work across the tree, then those that want to turn them off could?

There are some areas where the tests are already clean. It would be a shame to not keep them so, but I understand that FileCheck sometimes might need comments with length that don't meet the style guide

For now could you simply add a local .clang_format file in the test directory to turn clang-format off

I'm not sure I follow.. .What do you mean by "local"? Local to my tree or local to the test/ folder?
I was talking about the warnings which comes up in the Phab interface.

Bruno

Hum, so there is already test/.clang-format which does the above.

In the patch which motivated this email (https://reviews.llvm.org/D83183)
most of the noise is caused by complaints about the indentation of CHECK lines.

Perhaps I just need to do a quick clang-format and forget about it.

Bruno

In that specific example it looks like clang-format is actually being
helpful for the test file. If clang-format findings start to break test
cases thats when something should be done to silence them.

~Nathan

In that specific example it looks like clang-format is actually being
helpful for the test file. If clang-format findings start to break test
cases thats when something should be done to silence them.

It's suggesting formatting changes that aren't typically applied in
FileCheck tests because FileCheck is usually whitespace sensitive for
them.

~Aaron