[type-system-rewrite][PATCH] de-constify Type* in FunctionType::get()

Project Infrastructure LLVM Dev List Archives
1

This patch removes the deprecated form of FunctionType::get() which
takes "const Type*"s for the argument types, and replaces just enough
"const Type*" with "Type*" elsewhere to get everything building
cleanly again. (My motivation for this was that I was getting
ambiguous overload errors from some calls to FunctionType::get() in
the Clang source.)

Chris, are you interested in having this committed on the branch?

Thanks,
Jay.

deconstify-type.diff (38.8 KB)

2

Sure, go for it.

FWIW, I was waiting to do this (eventually "const Type" will just be "Type" everywhere).

I have a long list of cleanups that I want to land after the branch lands... but I was waiting for after the branch lands to make merging it less annoying and make things more incremental. Unfortunately I'm struggling to find time to finish things up and land the branch (this week for sure! :). Since you've already done this work, go ahead and land it if you'd like.

-Chris

3

I have a long list of cleanups that I want to land after the branch lands... but I was waiting for after the branch lands to make merging it less annoying and make things more incremental. Unfortunately I'm struggling to find time to finish things up and land the branch (this week for sure! :).

I'll wait until after the big merge-to-trunk then (unless anyone
really wants it on the branch now!).

Thanks,
Jay.