Typos in ARMInstrInfo.td ?

Project Infrastructure LLVM Dev List Archives
#1

Hi,

I think there are a set of typos in the ATOMIC_LOAD_UMIN_I* and ATOMIC_LOAD_UMAX_I*
pseudo-instructions .

Specifically,

def ATOMIC_LOAD_MIN_I32 : PseudoInst<
                 (outs GPR:$dst), (ins GPR:$ptr, GPR:$val), NoItinerary,
                 [(set GPR:$dst, (atomic_load_min_32 GPR:$ptr, GPR:$val))]>;

and

def ATOMIC_LOAD_UMIN_I32 : PseudoInst<
                 (outs GPR:$dst), (ins GPR:$ptr, GPR:$val), NoItinerary,
                 [(set GPR:$dst, (atomic_load_min_32 GPR:$ptr, GPR:$val))]>;

both reference atomic_load_min_32, and the latter should instead reference atomic_load_umin_32

Added here,
See http://llvm.org/viewvc/llvm-project/llvm/tags/RELEASE_30/final/lib/Target/ARM/ARMInstrInfo.td?diff_format=h&view=diff&r1=130233&r2=130234

Still present in trunk
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMInstrInfo.td?diff_format=h&view=annotate

Cheers,
George

#2

Thanks. Fixed with r147032.

Evan

#3

Hi Evan,

The problem repeats with the i8 and i16 variants, as well.

Cheers,
George

#4

Thanks, George. Fixed in r147064.

Chad