Hi all,
Phabricator(reviews.llvm.org) will be down for ~30 mins for an upgrade. Sorry for the short notice.
Regards,
Eric
That was a bad estimation. Database upgrade is taking time.
Is there any ETA?
-Krzysztof
Sorry for blocking everyone for so long.
It has been more than a year since the last upgrade, and mysql is adjusting schema for a table with ~150G data on a single VM instance. Sadly, the progress bar isn’t giving useful information (plus I am not a good system admin), so I couldn’t tell the ETA…
FYI: According to previous maintainer, it takes a couple of hours for the last upgrade, so this should be done within a few hours (hopefully!).
Sorry for blocking everyone for so long.
No pb, thanks very much for taking care of it 
It has been more than a year since the last upgrade, and mysql is adjusting schema for a table with ~150G data on a single VM instance.
150GB? I’m very surprised there is so much data in our phab! That seems huge…
My guess is that this includes all the diffs for every revision of every
review (as well as all the comments, etc), and it probably isn't as clever
with diffs as for example git. Which quite soon adds up to huge numbers
when you have tens of thousands of reviews.
Purse speculation of course, I have never looked inside phabricator (or for
that matter, any other code-review tool).
Still no word on when it will be back up? It’s not hung is it? 
According to top and iotop, mysqld is still working, and the progress bar did move by a little bit, so I think it’s just really slow. Apologies if this is blocking you.
Hi all,
Phabricator is (finally) back online! Let me know if you have any feedback or problem
Thanks,
Eric
You mentioned this was for an upgrade. Are there any major new features or bugfixes to be aware of?
It looks like the new phabricator sends html email by default.
I personally prefer text email. What do others think? Is this configurable in the new installation?
Thanks,
-- Sanjoy
One of the new “feature” is that emails are HTML only right now. Not quite nice for the archive (or for interacting by email).
See for instance: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160926/172081.html
(Also the funky "[Changed Subscribers] “ in the title)
Another issue is that we can’t delete unposted inline comment anymore.
I’ve switched the default email format to be plain text only now. This option should be per-user configurable, but somehow it is not shown in the “Settings”; I’ll try if I can make the option personalized.
Regarding new features and bug fixes in this upgrade, I don’t really have a list since the Phabricator we are running is the open-source repo + some local modification. The last merge was more than one year ago, so I guess there should be a long list of new features and bug fixes.
Some new features that I am aware of:
- Syntax highlighting.
- Patch size in email headers
- HTML email (disabled)
- More compatible with modern arc (the reason for this upgrade)
- and more to be discovered!
@Mehdi Deleting unposted inline comments works for me. At which patch did this issue occur?
- Eric
Thank you for working on this upgrade!
Is there a way that we can remove the [Request, X lines] tag from the
email headers on phab patches? While it's neat to understand how large
a patch is, you can get a rough feel for that information by looking
at the patch contents. Unfortunately, the extra text means we lose
information from the subject line when viewing emails from a smaller
screen (like a mobile device), so I'm not certain that the utility
warrants the cost (at least, to me).
~Aaron
Thanks for the feedback Aaron!
I’ve disabled it. I think the annoying part really is the status (e.g. Request, Closed etc) in the tag, and I am wondering if a tag with just line numbers like “(N Loc)” would be better. But I’m not really sure about the trade-off here.
- Eric
Thanks for the feedback Aaron!
I've disabled it. I think the annoying part really is the status (e.g.
Request, Closed etc) in the tag, and I am wondering if a tag with just line
numbers like "(N Loc)" would be better. But I'm not really sure about the
trade-off here.
Thank you for disabling it! Also, I agree, the Request, Closed, etc
stuff is also rather superfluous in some regards. But that at least
helps to determine whether the email is one I can archive immediately
or not (such as something that's been closed or abandoned), so perhaps
there is some utility with it? I do agree that it distracts from the
subject line, unfortunately.
~Aaron
I'd suggest that [PATCH] is a waste of screen real estate too - the
`Dnnnnn:` prefix makes it obvious. I do appreciate there's an argument
for having it for consistency with people who post patches directly to
llvm-commits.
Alex
Is there any way to disable emails when a revision is closed? I always find those annoying, especially when it’s a mass closing to clean out your dashboard
@Alex I tried glancing through emails in llvm-commits, and I found “[PATCH]” makes it easier to tell revisions from patches, and I guess people are also used to “[PATCH]” after all these years
@Zachary Yes! This option can be configured in “Email Preferences” in your personal setting, but I’m not sure if this should be disabled globally. For me personally, I’d like to be notified when a patch I am following is closed.
Although I am happy to make these changes if people want
Thanks,
Eric
I picked randomly in the “All revisions” list.
(For example: https://reviews.llvm.org/D25094 )
It seems I can delete comment unless I edited it first. Strange…