Visual C Patches for IsNAN.cpp and IsInf.cpp

Project Infrastructure LLVM Dev List Archives
1

I don't know if Paolo submitted his patches for these files, but they are not in the CVS -- I've chosen a slightly different strategy, adding a case that checks if the compiler is MSVC instead of adding HAVE_FINITE_IN_FLOAT_H and HAVE_ISNAN_IN_FLOAT_H to the config.h file.

I don't know which is the best approach, but this is the minimal patch to make it work...

m.

diff.txt (1.08 KB)

2

I submitted a patch keeping the traditional approach, HAVE_FINITE_IN_FLOAT_H and HAVE_ISNAN_IN_FLOAT...
Just another case added to the others instead of a custom approach.

3

Paolo Invernizzi wrote:

I submitted a patch keeping the traditional approach, HAVE_FINITE_IN_FLOAT_H and HAVE_ISNAN_IN_FLOAT...
Just another case added to the others instead of a custom approach.

It's a bit clumsy to do the configuration when you can't run the configure script, but I don't really mind either way. As long as one of the patches goes in as soon as possible and I know which one, I'm happy...

m.